DOC: fix DataFrame.nlargest and DataFrame.nsmallest doctests #23202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Moisan! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23202 +/- ##
==========================================
+ Coverage 92.18% 92.23% +0.04%
==========================================
Files 161 161
Lines 51184 51197 +13
==========================================
+ Hits 47185 47220 +35
+ Misses 3999 3977 -22
Continue to review full report at Codecov.
|
Contributor
|
lgtm. @jschendel @datapythonista pls merge if ok with you. |
jschendel
approved these changes
Oct 30, 2018
Member
jschendel
left a comment
jschendel
left a comment
There was a problem hiding this comment.
lgtm; will wait a bit for @datapythonista to review prior to merging
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
lgtm, just a typo and we can merge
Co-Authored-By: Moisan <[email protected]>
datapythonista
approved these changes
Nov 5, 2018
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
Merging on green. Thanks @Moisan
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffBased on #22459. Fix the docstring for
DataFrame.nlargestandDataFrame.nsmallest(since they are quite similar). I also updatedci/code_check.shI extended the existing doctest ofSeries.nlargestandSeries.nsmallest.