Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container start fails #42

Closed
MiguelElGallo opened this issue Jan 6, 2024 · 2 comments · Fixed by #52
Closed

Container start fails #42

MiguelElGallo opened this issue Jan 6, 2024 · 2 comments · Fixed by #52

Comments

@MiguelElGallo
Copy link

When using the container version, within Visual Studio code in MAC M2, the following error shows:

An error has occurred: FatalError: git failed. Is it installed, and are you in a Git repository directory? Check the log at /home/vscode/.cache/pre-commit/pre-commit.log [18551 ms] postCreateCommand failed with exit code 1. Skipping any further user-provided commands.

@pamelafox
Copy link
Owner

Did you do a git clone when opening it up? Or did you perhaps download the zip and open it up that way?

You could remove "pre-commit install" from devcontainer.json:
https://github.com/pamelafox/simple-fastapi-container/blob/main/.devcontainer/devcontainer.json#L45

That command assumes you're in a git repo, as it sets up pre-commit hooks.

@MiguelElGallo
Copy link
Author

Hi,
Yeah, I was guessing it is pre-commit.
I did a clone, which is why I thought it should work.
I removed pre-commit and it works.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants