Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency version pins in setup.py? #382

Closed
snarfed opened this issue Jul 14, 2022 · 2 comments · Fixed by #386
Closed

Relax dependency version pins in setup.py? #382

snarfed opened this issue Jul 14, 2022 · 2 comments · Fixed by #386

Comments

@snarfed
Copy link
Contributor

snarfed commented Jul 14, 2022

Hi! First of all, thank you for maintaining flask-caching. It's great!

I noticed that you all pinned your dependencies' versions recently in #368. Flask recently released v2.1.3, but flask-caching users won't be able to upgrade until you update your pin. Any chance you'd consider relaxing it to just major version, or anything else that you know you explicitly depend on and couldn't upgrade past? Specific version pins are great for applications, but overly restrictive for libraries since they cause problems like this. More on this here (search for library dependencies).

Thanks in advance!

@iROCKBUNNY
Copy link

iROCKBUNNY commented Jul 18, 2022

Dear @northernSage, hope you are doing well. Please address this issue when you see it. Thanks a lot!

@northernSage northernSage linked a pull request Jul 30, 2022 that will close this issue
2 tasks
@snarfed
Copy link
Contributor Author

snarfed commented Jul 30, 2022

Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants