Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass room names in lowerCase to fix #89 #92

Conversation

pascalwengerter
Copy link
Collaborator

@pascalwengerter pascalwengerter commented Jan 6, 2022

Potentially fixes #89, not sure if wanted from a product perspective though - as described in the issue it makes some users wonder "why this software doesn't work", but it also kinda increases the possibility for name-clashes of roomIds

@janlelis
Copy link
Member

janlelis commented Jan 9, 2022

Hey, thanks for the suggestion! I can understand the problem and I think I am slightly in favor of switching to case-insensitve room names. I have one remark / side-node (it's kind of offtopic to this PR, but somewhat relevant):

I have the idea of changing the current auto-generated room names from the UUID-like naming schema to shorter tokens, a little bit like the YouTube IDs. The great thing if we keep the current case-sensitive room IDs would be that the short tokens could be even shorter, because single characters carry more information.

What do all think about this? @farao @KopierKatze @paulgoetze @juwi

@pascalwengerter
Copy link
Collaborator Author

Does anyone has an opinion here? :)

@pascalwengerter
Copy link
Collaborator Author

Closing as not actionable and to be discussed in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make room IDs case insensitive
2 participants