Memory gauges report null when data is unavailable #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the default `-1` values were used, resulting in confusing dashboards that didn't make it obvious the data was unavailable.
Generate changelog in
|
carterkozak
requested review from
fawind and
schlosna
and removed request for
robert3005
schlosna
reviewed
Mar 17, 2022
| + memoryBean.getNonHeapMemoryUsage().getMax()); | ||
| metrics.totalInit( | ||
| (NonNegativeGauge) () -> memoryBean.getHeapMemoryUsage().getInit() | ||
| + memoryBean.getNonHeapMemoryUsage().getInit()); |
Contributor
There was a problem hiding this comment.
are these computations problematic if one or both are not available?
Contributor
Author
There was a problem hiding this comment.
Probably worth checking both, in practice they’re all or nothing in my experience, but that could change.
carterkozak
pushed a commit
to palantir/gradle-baseline
that referenced
this pull request
Mar 18, 2022
See the confusing failures with no source location on palantir/tritium#1392 due to assertions on Gauge values.
schlosna
reviewed
Mar 18, 2022
| metrics.totalInit((Gauge<Long>) () -> { | ||
| long heap = memoryBean.getHeapMemoryUsage().getInit(); | ||
| long nonHeap = memoryBean.getNonHeapMemoryUsage().getInit(); | ||
| return (heap < 0 || nonHeap < 0) ? null : heap + nonHeap; |
Contributor
There was a problem hiding this comment.
I assume the intent here to avoid producing any value if one don't have just one component (e.g. if we have heap init but do not have non-heap init)?
Contributor
schlosna
approved these changes
Mar 18, 2022
Contributor
Author
|
👍 |
Collaborator
|
Released 0.44.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the default
-1values were used, resulting inconfusing dashboards that didn't make it obvious the data was
unavailable.
==COMMIT_MSG==
Memory gauges report null when data is unavailable
==COMMIT_MSG==