Apply AutoCloseableMustBeClosed #1009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Mar 8, 2021
| } | ||
|
|
||
| @Override | ||
| @MustBeClosed |
Contributor
There was a problem hiding this comment.
Perhaps we should disable these on overrides unless the overridden method is also annotated with @MustBeClosed?
Contributor
Author
There was a problem hiding this comment.
Yeah, that would help avoid some noise as this rolls out, then we can ratchet it up.
./gradlew compileJava compileTestJava -PerrorProneApply=AutoCloseableMustBeClosed
schlosna
force-pushed
the
ds/AutoCloseableMustBeClosed
branch
from
6b83b29 to
92b072f
Compare
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
AutoCloseableMustBeClosedfrom palantir/gradle-baseline#1673Before this PR
Methods returning
AutoCloseablewere not marked as@MustBeClosedAfter this PR
==COMMIT_MSG==
Methods returning
AutoCloseablemarked as@MustBeClosed./gradlew clean compileJava compileTestJava -PerrorProneApply=AutoCloseableMustBeClosed
./gradlew format
==COMMIT_MSG==
Possible downsides?