Skip to content

Commit 1e18679

Browse files
Excavator: Upgrades Baseline to the latest version
1 parent 44cdd01 commit 1e18679

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ buildscript {
2525
classpath 'com.palantir.javaformat:gradle-palantir-java-format:2.2.0'
2626
classpath 'com.palantir.gradle.revapi:gradle-revapi:1.5.0'
2727
classpath 'gradle.plugin.com.github.jengelman.gradle.plugins:shadow:7.0.0'
28-
classpath 'com.palantir.baseline:gradle-baseline-java:4.9.0'
28+
classpath 'com.palantir.baseline:gradle-baseline-java:4.22.0'
2929
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.3'
3030
classpath 'gradle.plugin.org.inferred:gradle-processors:3.6.0'
3131
classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:2.0.0'

tracing-test-utils/src/main/java/com/palantir/tracing/HtmlFormatter.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,12 @@
2626
import java.nio.charset.StandardCharsets;
2727
import java.nio.file.Files;
2828
import java.nio.file.Path;
29+
import java.time.Duration;
2930
import java.time.Instant;
3031
import java.time.OffsetDateTime;
3132
import java.time.ZoneOffset;
3233
import java.time.format.DateTimeFormatter;
34+
import java.time.temporal.ChronoUnit;
3335
import java.util.Collection;
3436
import java.util.Comparator;
3537
import java.util.Map;
@@ -116,11 +118,11 @@ private void renderAllSpansForOneTraceId(String traceId, SpanAnalyzer.Result ana
116118
}
117119

118120
private void header(StringBuilder sb) throws IOException {
119-
OffsetDateTime startTime = Instant.ofEpochMilli(
120-
TimeUnit.MILLISECONDS.convert(config.bounds().startMicros(), TimeUnit.MICROSECONDS))
121+
OffsetDateTime startTime = Instant.ofEpochMilli(TimeUnit.MILLISECONDS.convert(
122+
Duration.of(config.bounds().startMicros(), ChronoUnit.MICROS)))
121123
.atOffset(ZoneOffset.UTC);
122-
OffsetDateTime endTime = Instant.ofEpochMilli(
123-
TimeUnit.MILLISECONDS.convert(config.bounds().endNanos(), TimeUnit.NANOSECONDS))
124+
OffsetDateTime endTime = Instant.ofEpochMilli(TimeUnit.MILLISECONDS.convert(
125+
Duration.ofNanos(config.bounds().endNanos())))
124126
.atOffset(ZoneOffset.UTC);
125127
sb.append(template(
126128
"header.html",
@@ -167,7 +169,7 @@ private void formatSpan(Span span, boolean suspectedCollision, StringBuilder sb)
167169
Utils.renderDuration(
168170
transposedStartMicros
169171
+ TimeUnit.MICROSECONDS.convert(
170-
span.getDurationNanoSeconds(), TimeUnit.NANOSECONDS),
172+
Duration.ofNanos(span.getDurationNanoSeconds())),
171173
TimeUnit.MICROSECONDS))
172174
.put("{{OPERATION}}", span.getOperation())
173175
.put("{{DURATION}}", Utils.renderDuration(span.getDurationNanoSeconds(), TimeUnit.NANOSECONDS))

tracing-test-utils/src/main/java/com/palantir/tracing/TimeBounds.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
package com.palantir.tracing;
1818

1919
import com.palantir.tracing.api.Span;
20+
import java.time.Duration;
21+
import java.time.temporal.ChronoUnit;
2022
import java.util.Collection;
2123
import java.util.Comparator;
2224
import java.util.concurrent.TimeUnit;
@@ -31,24 +33,24 @@ interface TimeBounds extends Comparable<TimeBounds> {
3133
long endNanos();
3234

3335
default long startNanos() {
34-
return TimeUnit.NANOSECONDS.convert(startMicros(), TimeUnit.MICROSECONDS);
36+
return TimeUnit.NANOSECONDS.convert(Duration.of(startMicros(), ChronoUnit.MICROS));
3537
}
3638

3739
default long durationNanos() {
3840
return endNanos() - startNanos();
3941
}
4042

4143
default long durationMicros() {
42-
return TimeUnit.MICROSECONDS.convert(durationNanos(), TimeUnit.NANOSECONDS);
44+
return TimeUnit.MICROSECONDS.convert(Duration.ofNanos(durationNanos()));
4345
}
4446

4547
static TimeBounds fromSpans(Collection<Span> spans) {
4648
long earliestStartMicros =
4749
spans.stream().mapToLong(Span::getStartTimeMicroSeconds).min().getAsLong();
4850
long latestEndNanos = spans.stream()
4951
.mapToLong(span -> {
50-
long startTimeNanos =
51-
TimeUnit.NANOSECONDS.convert(span.getStartTimeMicroSeconds(), TimeUnit.MICROSECONDS);
52+
long startTimeNanos = TimeUnit.NANOSECONDS.convert(
53+
Duration.of(span.getStartTimeMicroSeconds(), ChronoUnit.MICROS));
5254
return startTimeNanos + span.getDurationNanoSeconds();
5355
})
5456
.max()

0 commit comments

Comments
 (0)