Skip to content

Commit abf0439

Browse files
authored
Run java lint by default (#180)
1 parent 4a5890d commit abf0439

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import java.lang.reflect.Method;
2323
import java.nio.ByteBuffer;
2424
import java.nio.charset.StandardCharsets;
25-
import java.nio.file.Files;
2625
import java.util.List;
2726
import java.util.Map;
2827

common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ public void getMetrics(MetricsCollector collector, boolean all) {
5353
}
5454

5555
@VisibleForTesting
56-
public static void collectMetric(MetricsRecordBuilder metricsRecordBuilder, String name, Metric metric) {
56+
public static void collectMetric(
57+
MetricsRecordBuilder metricsRecordBuilder, String name, Metric metric) {
5758

5859
// The metric types used in ExternalShuffleBlockHandler.ShuffleMetrics
5960
if (metric instanceof Timer) {

dev/run-tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ def main():
582582
or f.endswith("checkstyle.xml")
583583
or f.endswith("checkstyle-suppressions.xml")
584584
for f in changed_files):
585-
# run_java_style_checks()
585+
run_java_style_checks()
586586
pass
587587
if not changed_files or any(f.endswith(".py") for f in changed_files):
588588
run_python_style_checks()

sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,8 @@ public void initialize(InputSplit inputSplit, TaskAttemptContext taskAttemptCont
154154
ReadSupport.ReadContext readContext = readSupport.init(new InitContext(
155155
taskAttemptContext.getConfiguration(), toSetMultiMap(fileMetadata), fileSchema));
156156
this.requestedSchema = readContext.getRequestedSchema();
157-
this.reader = ParquetFileReader.open(configuration, file, new ParquetMetadata(footer.getFileMetaData(), blocks));
157+
this.reader = ParquetFileReader.open(
158+
configuration, file, new ParquetMetadata(footer.getFileMetaData(), blocks));
158159
this.reader.setRequestedSchema(requestedSchema);
159160
String sparkRequestedSchemaString =
160161
configuration.get(ParquetReadSupport$.MODULE$.SPARK_ROW_REQUESTED_SCHEMA());

0 commit comments

Comments
 (0)