address comments

Author: fsamuel-bs

core/src/main/scala/org/apache/spark/executor/Executor.scala

@@ -436,8 +436,8 @@ private[spark] class Executor(
           val res = task.run(
             taskAttemptId = taskId,
             attemptNumber = taskDescription.attemptNumber,
-            executorPlugins = executorPlugins,
-            metricsSystem = env.metricsSystem)
+            metricsSystem = env.metricsSystem,
+            executorPlugins = executorPlugins)
           threwException = false
           res
         } {

core/src/main/scala/org/apache/spark/scheduler/Task.scala

@@ -83,7 +83,7 @@ private[spark] abstract class Task[T](
       taskAttemptId: Long,
       attemptNumber: Int,
       metricsSystem: MetricsSystem,
-      executorPlugins: Seq[ExecutorPlugin]): T = {
+      executorPlugins: Seq[ExecutorPlugin] = Seq.empty): T = {
     SparkEnv.get.blockManager.registerTask(taskAttemptId)
     // TODO SPARK-24874 Allow create BarrierTaskContext based on partitions, instead of whether
     // the stage is barrier.

core/src/test/scala/org/apache/spark/scheduler/TaskContextSuite.scala

@@ -70,7 +70,7 @@ class TaskContextSuite extends SparkFunSuite with BeforeAndAfter with LocalSpark
       0, 0, taskBinary, rdd.partitions(0), Seq.empty, 0, new Properties,
       closureSerializer.serialize(TaskMetrics.registered).array())
     intercept[RuntimeException] {
-      task.run(0, 0, null, Seq.empty)
+      task.run(0, 0, null)
     }
     assert(TaskContextSuite.completed === true)
   }
@@ -92,7 +92,7 @@ class TaskContextSuite extends SparkFunSuite with BeforeAndAfter with LocalSpark
       0, 0, taskBinary, rdd.partitions(0), Seq.empty, 0, new Properties,
       closureSerializer.serialize(TaskMetrics.registered).array())
     intercept[RuntimeException] {
-      task.run(0, 0, null, Seq.empty)
+      task.run(0, 0, null)
     }
     assert(TaskContextSuite.lastError.getMessage == "damn error")
   }