Apply --add-exports to Java 16+ services based on manifest entries
#1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
force-pushed
the
ckozak/add_exports
branch
from
2b06837 to
1acec3d
Compare
fawind
reviewed
Nov 3, 2021
| * Utility functionality which mirrors {@code Add-Exports} plumbing from | ||
| * <a href="https://github.com/palantir/gradle-baseline/pull/1944">gradle-baseline#1944</a>. | ||
| */ | ||
| final class ModuleExports { |
Contributor
There was a problem hiding this comment.
I think it would be nice to to also have a small explanation here instead of just linking to the PR. Something similar to what you added in:
Contributor
Author
There was a problem hiding this comment.
Good call, updated!
fawind
approved these changes
Nov 3, 2021
Contributor
fawind
left a comment
fawind
left a comment
There was a problem hiding this comment.
Looks good, I think the code duplication with the gradle-baseline feature is actually not too bad!
iamdanfox
reviewed
Nov 3, 2021
| classpath.getFiles().stream().flatMap(file -> { | ||
| try { | ||
| if (file.getName().endsWith(".jar") && file.isFile()) { | ||
| JarFile jar = new JarFile(file); |
Contributor
There was a problem hiding this comment.
driveby: shouldn't JarFiles be in a try-with-resources block?
public void close() throws IOException {
if (closeRequested) {
return;
}
closeRequested = true;
synchronized (this) {
// Close streams, release their inflaters, release cached inflaters
// and release zip source
try {
res.clean();
} catch (UncheckedIOException ioe) {
throw ioe.getCause();
}
}
}
Contributor
Author
There was a problem hiding this comment.
Good shout, we should have an error-prone rule for this!
added 2 commits
November 3, 2021 10:25
Collaborator
|
Released 7.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the same functionality as
palantir/gradle-baseline#1944
We're piggy-backing off the
Add-Exportsmanifest property to collect exports required for any given application based on the libraries it uses.==COMMIT_MSG==
Apply
--add-exportsto Java 16+ services based on manifest entries==COMMIT_MSG==