Skip to content

Conversation

@leonz
Copy link

@leonz leonz commented Dec 6, 2022

Backport of #638 on 2.x

  • PathConvertingFileSystem renames paths without creating new FileStatus objects

  • Add generated changelog entries

  • Reflect updated FileStatus conversion in test

Co-authored-by: svc-changelog [email protected]

Before this PR

After this PR

==COMMIT_MSG==
PathConvertingFileSystem converts FileStatus objects in-place
==COMMIT_MSG==

Possible downsides?

* PathConvertingFileSystem renames paths without creating new FileStatus objects

* Add generated changelog entries

* Reflect updated FileStatus conversion in test

Co-authored-by: svc-changelog <[email protected]>
@leonz leonz changed the base branch from develop to release/2.x December 6, 2022 20:46
@leonz leonz changed the base branch from release/2.x to release/2.10.0 December 6, 2022 20:47
@leonz leonz force-pushed the 2.x/backport-file-status branch from d60f054 to 3d89e58 Compare December 6, 2022 20:48
schlosna
schlosna previously approved these changes Dec 6, 2022
@schlosna
Copy link
Contributor

schlosna commented Dec 6, 2022

👍

@policy-bot policy-bot bot dismissed schlosna’s stale review December 6, 2022 20:52

Dismissed because the approval was invalidated by another commit

@schlosna schlosna merged commit 164e93c into release/2.10.0 Dec 6, 2022
@schlosna schlosna deleted the 2.x/backport-file-status branch December 6, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants