Skip to content

Delegate to batch write methods #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Delegate to batch write methods #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions hadoop-crypto/src/main/java/com/palantir/hadoop2/cipher/FsCipherOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.palantir.crypto2.cipher.CipherStreamSupplierImpl;
import com.palantir.crypto2.cipher.SeekableCipher;
import java.io.FilterOutputStream;
import java.io.IOException;
import javax.crypto.Cipher;
import org.apache.hadoop.fs.FSDataOutputStream;

Expand All @@ -39,4 +40,14 @@ public FsCipherOutputStream(FSDataOutputStream delegate, SeekableCipher cipher)
super(supplier.getOutputStream(delegate, cipher.initCipher(Cipher.ENCRYPT_MODE)));
}

@Override
public void write(byte[] bytes, int off, int len) throws IOException {
out.write(bytes, off, len);
}

@Override
public void write(byte[] bytes) throws IOException {
out.write(bytes);
}

Copy link

@uschi2000 uschi2000 Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eclipse user?

}
15 changes: 15 additions & 0 deletions hadoop-crypto/src/test/java/com/palantir/hadoop2/cipher/FsCipherOutputStreamTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import com.palantir.crypto2.cipher.CipherStreamSupplier;
import com.palantir.crypto2.cipher.SeekableCipher;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.security.InvalidAlgorithmParameterException;
import java.security.InvalidKeyException;
import java.security.NoSuchAlgorithmException;
Expand All @@ -37,6 +38,8 @@

public final class FsCipherOutputStreamTest {

private static final byte[] bytes = "bytes".getBytes(StandardCharsets.UTF_8);

private FSDataOutputStream os;
private Cipher initCipher;
private SeekableCipher seekableCipher;
Expand Down Expand Up @@ -72,4 +75,16 @@ public void testWrite() throws IOException {
verify(cos).write(0);
}

@Test
public void testWrite_callsWriteWithLength() throws IOException {
scos.write(bytes, 0, bytes.length);
verify(cos).write(bytes, 0, bytes.length);
}

@Test
public void testWrite_callsBatchWrite() throws IOException {
scos.write(bytes);
verify(cos).write(bytes);
}

}