Skip to content

Conversation

@CRogers
Copy link
Contributor

@CRogers CRogers commented Jun 12, 2025

Before this PR

When we upgraded errorprone in #3121, it brought in a load of new checks. Some of these are not valuable or relevant with how we write code at Palantir.

We disabled some in #3123 already, but there are more.

After this PR

==COMMIT_MSG==
Disable some new low-value Google provided errorprone checks:

  • CatchingUnchecked
  • DifferentNameButSame
  • PreferredInterfaceType
  • ThrowSpecificExceptions
  • UnnecessaryFinal
  • UnnecessaryFullyQualified
  • UnnecessarilyVisible
    ==COMMIT_MSG==

Possible downsides?

This is kinda a stop-gap measure until we fix suppressible-error-prone suppressing warnings.

@changelog-app
Copy link

changelog-app bot commented Jun 12, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Disable some new low-value Google provided errorprone checks:

  • CatchingUnchecked
  • DifferentNameButSame
  • PreferredInterfaceType
  • ThrowSpecificExceptions
  • UnnecessaryFinal
  • UnnecessaryFullyQualified
  • UnnecessarilyVisible

Check the box to generate changelog(s)

  • Generate changelog entry

bmarcaur
bmarcaur previously approved these changes Jun 12, 2025
@felixdesouza
Copy link
Contributor

👍

@felixdesouza
Copy link
Contributor

👍

@bulldozer-bot bulldozer-bot bot merged commit 287f2a4 into develop Jun 12, 2025
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/disable-some-errorprones branch June 12, 2025 17:02
@autorelease3
Copy link

autorelease3 bot commented Jun 12, 2025

Released 6.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants