Skip to content

Conversation

@FinlayRJW
Copy link
Contributor

Before this PR

Inellij plugins had to manually disable error prone options

After this PR

Now error prone options are auto disabled for intellij plugins

@changelog-app
Copy link

changelog-app bot commented Sep 18, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

disable PreferSafeLogger and StrictUnusedVariable for intellij

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 32a3d42 into develop Sep 18, 2024
@bulldozer-bot bulldozer-bot bot deleted the finlayw/intellij_disable_safelogger branch September 18, 2024 13:09
@autorelease3
Copy link

autorelease3 bot commented Sep 18, 2024

Released 5.67.0

@pkoenig10
Copy link
Member

Hey, I don't think this is a good idea for the reasons mentioned in #2010 (comment).

If my compilation is going to fail in CI, I want to to fail locally. Otherwise developers just waste cycles when they push changes and then compilation fails in CI. And when I need to fix this I want to be able to verify locally that I've addressed all the failures, otherwise I just have to repeat this cycle again.

I think we can debate what the correct default is, but I feel pretty strongly that we must at least give users the option to enable these if they want.

@CRogers CRogers changed the title disable PreferSafeLogger and StrictUnusedVariable for intellij disable PreferSafeLogger and StrictUnusedVariable for intellij plugin development Sep 19, 2024
@pkoenig10
Copy link
Member

Ignore me, I misunderstood this PR. This applies to IntelliJ plugin development, not compilation in IntelliJ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants