Add check replacing stream.sorted().findFirst() with stream.min()
#2555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 5, 2023 18:04
Generate changelog in
|
carterkozak
reviewed
Apr 27, 2023
| return Description.NO_MATCH; | ||
| } | ||
|
|
||
| if (Matchers.receiverOfInvocation(STREAM_SORTED_NO_PARAMS_MATCHER).matches(tree, state)) { |
Contributor
There was a problem hiding this comment.
Let's extract the Matchers.receiverOfInvocation( Matcher instances to static fields so they can be reused.
carterkozak
reviewed
Apr 27, 2023
| return describeMatch( | ||
| tree, | ||
| SuggestedFix.builder() | ||
| .replace(tree, state.getSourceForNode(stream) + ".min(Comparator.naturalOrder())") |
Contributor
There was a problem hiding this comment.
it may be slightly cleaner to use an index-based replace call from the beginning of sorted to the end of findFirst. That way we're more likely to preserve comments and such. Doesn't make a great deal of differnce either way though :-]
carterkozak
reviewed
Apr 27, 2023
| state.getSourceForNode(stream) + ".min(" | ||
| + state.getSourceForNode( | ||
| sortedTree.getArguments().get(0)) + ")") | ||
| .addImport(Comparator.class.getCanonicalName()) |
Contributor
There was a problem hiding this comment.
I don't think this addImport is used
carterkozak
reviewed
Apr 27, 2023
|
|
||
| private RefactoringValidator fix() { | ||
| return RefactoringValidator.of(SortedStreamFirstElement.class, getClass()); | ||
| } |
added 6 commits
May 30, 2023 18:24
…aseline into add-check-sorted-first
carterkozak
approved these changes
Jun 1, 2023
Contributor
carterkozak
left a comment
carterkozak
left a comment
There was a problem hiding this comment.
Looks great, thanks @mpritham!
Collaborator
|
Released 5.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
As part of this PR, the check to recommend using
stream.min()overstream.sorted().findFirst()was removed. This PR adds an error-prone rule with the same effect.After this PR
==COMMIT_MSG==
Add check replacing
stream.sorted().findFirst()withstream.min()==COMMIT_MSG==