Java compilation warnings and errors are no longer limited to the first 100 #1890
Conversation
Generate changelog in
|
| project.getTasks().withType(JavaCompile.class).configureEach(javaCompileTask -> { | ||
| List<String> compilerArgs = javaCompileTask.getOptions().getCompilerArgs(); | ||
| // Avoid overriding options that have already been set | ||
| if (!compilerArgs.contains(MAX_WARNINGS_ARG)) { |
There was a problem hiding this comment.
Would we want this to work if people override after applying the plugin too? If so, we'd probably want to put this in a project.afterEvaluate to run after people have had a chance to change it.
There was a problem hiding this comment.
I think it does, but only due to the fact later arguments take precedence over earlier instances. The afterEvaluate will be cleaner :-)
Note that the same potential duplication can occur if commandlineargumentproviders are used because I'm not checking those, we take advantage of knowing they're applied after the fixed args. I figured we don't want to evaluate providers unnecessarily as part of this check due to potential side-effects given the worst case result still has the desired behavior.
|
Released 4.22.0 |
==COMMIT_MSG==
Java compilation warnings and errors are no longer limited to the first 100
==COMMIT_MSG==