Fix false positive ClassInitializationDeadlock on .class access
#1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing the class field does not initialize a class. There are operations one can invoke upon the class object which will initialize the class, but those are relatively rare and out of scope for this check.
Generate changelog in
|
fawind
approved these changes
Feb 23, 2021
Contributor
fawind
left a comment
fawind
left a comment
There was a problem hiding this comment.
Makes sense to allow this!
bulldozer-bot
bot
deleted the
ckozak/ClassInitializationDeadlock_class_access
branch
Collaborator
|
Released 3.68.1 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
False positive preventing baseline upgrades in sls-packaging: palantir/sls-packaging#1062
After this PR
Accessing the class field does not initialize a class.
==COMMIT_MSG==
Fix false positive ClassInitializationDeadlock on
.classaccess==COMMIT_MSG==
Possible downsides?
There are operations one can invoke upon the
Classobject which will initializethe referenced class, but those are relatively rare and out of scope for this check.