Disable WhitespaceAround when using palantir-java-format #1603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The
WhitespaceAroundcheckstyle check conflicts with how palantir-java-format (correctly) formats empty blocks in switch expressions.The following code:
Results in the following errors:
See internal build https://c.p.b/gh/foundry/mp/236221
After this PR
The
WhitespaceAroundcheckstyle check is removed when using palantir-java-format.This is similar to what we've done previously for other checks in #987, #1205, and #1278.
I've also taken the liberty to refactor this to use Java's XML tooling to make it a bit more robust and easier to read/modify. This did result in some slight formatting changes to the output. See https://g.p.b/foundry/mp/commit/acc37f76 for an example of the changes.