checkstyle 8.33 -> 8.36.1

[iamdanfox]

I tried to use a record but got a lame error:

[ant:checkstyle] Running Checkstyle 8.33 on 4 files
[ant:checkstyle] [ERROR] /Volumes/git/template-witchcraft/witchcraft-example/src/main/java/com/palantir/witchcraftexample/WitchcraftExampleResource.java:19:12: Method name 'Foo' must match pattern '^[a-z][a-zA-Z0-9_]+$'. [MethodName]

After this PR

I think support was just added to checkstyle in checkstyle/checkstyle#8023 (8.35), but figured we might as well dial up to latest 🤷.

Release notes here: https://checkstyle.sourceforge.io/releasenotes.html

==COMMIT_MSG==
checkstyle 8.33 -> 8.36.1
==COMMIT_MSG==

I trialled this locally by setting:

    checkstyle {
        toolVersion = '8.36.1'
    }

Possible downsides?

• new rules might wreck us in new and exciting ways.

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

checkstyle 8.33 -> 8.36.1, which enables support for new language features like records.

Check the box to generate changelog(s)

• Generate changelog entry

[carterkozak]

lgtm -- please test on a real project before merging :-)

[iamdanfox]

Verified it passed on contour :)

[svc-autorelease]

Released 3.39.0