Ignore case in checkstyle TODO rule #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
dansanduleac
approved these changes
Jul 24, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
TODO comments of the form
// TODO: somethingare disallowed, but the rule is case sensitive so// todo: somethingdoesn't get caught.After this PR
==COMMIT_MSG==
Make TODO checkstyle rule case insensitive
==COMMIT_MSG==
I found 19 results in our product repos that would be blocked by this change based on a simple (incomplete) regex.
An alternative approach would be to leave it case sensitive and add a separate rule that disallows lower-case TODO rules, but that would affect more repos.
==MERGE_WHEN_READY==