--write-locks no longer implicitly runs checkClassUniqueness task #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
force-pushed
the
dfox/faster-write-locks
branch
from
af677fa to
57ef7b4
Compare
carterkozak
approved these changes
Jun 3, 2020
Contributor
carterkozak
left a comment
carterkozak
left a comment
There was a problem hiding this comment.
Looks like our error message already suggests checkClassUniqueness --write-locks 👍
Collaborator
|
Released 3.24.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I've become frustrated with how the local experience of writing
./gradlew --write-lockshas become very slow. This is often because checkClassUniqueness is a pretty meaty task, which ends up analyzing all jars on the classpath.After this PR
==COMMIT_MSG==
Running
./gradlew --write-locksshould be faster now, as it doesn't update yourbaseline-class-uniqueness.lockfile implicitly anymore. To update this, you need to run./gradlew checkClassUniqueness --write-locks.==COMMIT_MSG==
Possible downsides?
A big downside here is: if we just merge this PR, then a bunch of excavators will probably start opening PRs with out of date baseline-class-uniqueness.lock files, leading to frustrated devs.