baseline-exact-dependencies stops resolving compileOnly #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at runtimeClasspath" This reverts commit 02553f8
Generate changelog in
|
CRogers
approved these changes
Feb 26, 2020
Collaborator
|
Released 3.5.1 |
This was referenced Feb 26, 2020
This was referenced Feb 26, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
baseline-exact-dependencieswas trying to resolvecompileOnlyandannotationProcessorin order to determine dependencies that should be ignored because they are "source-only".This now breaks with 3.5.0 / #1254 because we've banned resolving
compileOnlydirectly.After this PR
==COMMIT_MSG==
Fix baseline-exact-dependencies to no longer resolve compileOnly directly.
Instead, we create another configuration extending from
compileOnly, which we tell to resolve only compile variants (so they'll be guaranteed to be the same variants as what's resolved bycompileClasspath).Also, excluding
annotationProcessorwas bogus because annotationProcessor is entirely independent from the other java configurations and doesn't end up in compileClasspath at all.==COMMIT_MSG==
Possible downsides?