Revert "Refaster rule to remove unnecessary supplier creation (#1059)" #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refaster rule breaks the common pattern: `Suppliers.memoize(supplier::get)`. This reverts commit 686d71f.
Generate changelog in
|
iamdanfox
approved these changes
Nov 21, 2019
Contributor
iamdanfox
left a comment
iamdanfox
left a comment
There was a problem hiding this comment.
Ah unlucky - spotted in a large internal repo by any chance?
Collaborator
|
Released 2.35.1 |
This was referenced Nov 21, 2019
This was referenced Nov 21, 2019
This was referenced Nov 29, 2019
This was referenced Dec 16, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refaster rule breaks the common pattern:
Suppliers.memoize(supplier::get).This reverts commit 686d71f.
After this PR
==COMMIT_MSG==
Revert "Refaster rule to remove unnecessary supplier creation (#1059)"
The refaster rule breaks the common pattern:
Suppliers.memoize(supplier::get).==COMMIT_MSG==