Create-able Select components #3304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
reviewed
Jan 21, 2019
|
|
||
| export function createFilm(title: string): IFilm { | ||
| return { | ||
| rank: 100 + Math.floor(Math.random() * 100 + 1), |
|
|
||
| Use the `createItemFromQuery` prop to allow `Select<T>` to create new items. `createItemFromQuery` specifies how to turn a | ||
| user-entered query string into an item of type `<T>` that `Select` understands. You should also provide the `createItemRenderer` | ||
| prop to render a custom `MenuItem` to indicate that users can create new items. |
There was a problem hiding this comment.
let's add a simple code sample here that demonstrates using both props.
| it("renders create item if filtering returns empty list", () => { | ||
| const wrapper = render({ | ||
| ...testCreateProps, | ||
| items: [], |
There was a problem hiding this comment.
use the real item list so it's actually filtering instead of always being an empty list
|
Closing in favor of #3306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1710
Changes proposed in this pull request:
IListItemsProps, now takes two additional props:createItemFromQuery?: (query: string) => Twhich converts a query to a new item; if this prop is present, the select component is considered "create-able";createItemRenderer?: (query: string, handleClick: React.MouseEventHandler<HTMLElement>) => JSX.Element | undefinedwhich could be used to render a customMenuItemat the end of the list, that represents "create a new element from query".