Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateInput tab fix #3038

Merged
merged 1 commit into from
Oct 25, 2018
Merged

DateInput tab fix #3038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/datetime/src/dateInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,7 @@ export class DateInput extends AbstractPureComponent<IDateInputProps, IDateInput
if (e.which === Keys.ENTER) {
const nextDate = this.parseDate(this.state.valueString);
this.handleDateChange(nextDate, true, true);
} else if (e.which === Keys.TAB && e.shiftKey) {
// close the popover if focus will move to the previous element on
// the page. tabbing forward should *not* close the popover, because
// focus will be moving into the popover itself.
} else if (e.which === Keys.TAB) {
this.setState({ isOpen: false });
} else if (e.which === Keys.ESCAPE) {
this.setState({ isOpen: false });
Expand Down