Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow list does not detect popover size correctly due to scale #5167

Closed
dylanrcooke opened this issue Mar 15, 2022 · 0 comments · Fixed by #5168
Closed

Overflow list does not detect popover size correctly due to scale #5167

dylanrcooke opened this issue Mar 15, 2022 · 0 comments · Fixed by #5168

Comments

@dylanrcooke
Copy link
Contributor

dylanrcooke commented Mar 15, 2022

Code Sandbox

Link to a minimal repro https://codesandbox.io/s/blueprint-sandbox-forked-xcw0jp?file=/src/index.tsx

Steps to reproduce

Use an overflow list in a popover with the minimal prop set to false

Actual behavior

The overflow list will never render more than one element

Expected behavior

The overflow list renders as many elements as fit in the container

Possible solution

  • We currently scale the popover in css here
  • If we switch to using element.offsetWidth instead of element.getBoundingClientRect().width it will remove the scale factor from the spacer repartition check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant