You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all I should l say thx for cool toolkit)
I've got a console warning when update to a new version.
Environment
Package version(s): "^3.24.0",
Browser and OS versions: doesn't matter
I haven't checked it on prod env, but it seems that it happens in dev mode.
Steps to reproduce
Add Button component
Add outline props to that component according to doc (eg outline={true})
Open app in browser
Actual behavior
React-dom warning in console.
react-dom.development.js:530 Warning: Received true for a non-boolean attribute outlined.
If you want to write it to the DOM, pass a string instead: outlined="true" or outlined={value.toString()}.
in button (created by Blueprint3.Button)
Expected behavior
console without warning
Possible solution
Are you sure that you do not forget to add "outlined" attr to INVALID_PROPS variable that is used by removeNonHTMLProps?
node_modules/@blueprintjs/core/src/common/props.ts
The text was updated successfully, but these errors were encountered:
s-solyanik
changed the title
Outline prop for Button component
Outlined props: Button component
Mar 3, 2020
Hello.
First of all I should l say thx for cool toolkit)
I've got a console warning when update to a new version.
Environment
I haven't checked it on prod env, but it seems that it happens in dev mode.
Steps to reproduce
Actual behavior
React-dom warning in console.
react-dom.development.js:530 Warning: Received
true
for a non-boolean attributeoutlined
.If you want to write it to the DOM, pass a string instead: outlined="true" or outlined={value.toString()}.
in button (created by Blueprint3.Button)
Expected behavior
console without warning
Possible solution
Are you sure that you do not forget to add "outlined" attr to INVALID_PROPS variable that is used by removeNonHTMLProps?
node_modules/@blueprintjs/core/src/common/props.ts
The text was updated successfully, but these errors were encountered: