Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlined props: Button component #3997

Closed
s-solyanik opened this issue Mar 3, 2020 · 1 comment · Fixed by #3998
Closed

Outlined props: Button component #3997

s-solyanik opened this issue Mar 3, 2020 · 1 comment · Fixed by #3998

Comments

@s-solyanik
Copy link

s-solyanik commented Mar 3, 2020

Hello.

First of all I should l say thx for cool toolkit)
I've got a console warning when update to a new version.

Environment

  • Package version(s): "^3.24.0",
  • Browser and OS versions: doesn't matter

I haven't checked it on prod env, but it seems that it happens in dev mode.

Steps to reproduce

  1. Add Button component
  2. Add outline props to that component according to doc (eg outline={true})
  3. Open app in browser

Actual behavior

React-dom warning in console.
react-dom.development.js:530 Warning: Received true for a non-boolean attribute outlined.

If you want to write it to the DOM, pass a string instead: outlined="true" or outlined={value.toString()}.
in button (created by Blueprint3.Button)

Expected behavior

console without warning

Possible solution

Are you sure that you do not forget to add "outlined" attr to INVALID_PROPS variable that is used by removeNonHTMLProps?
node_modules/@blueprintjs/core/src/common/props.ts

@s-solyanik s-solyanik changed the title Outline prop for Button component Outlined props: Button component Mar 3, 2020
@adidahiya
Copy link
Contributor

you're right, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants