You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do the following import: import { Position, Toaster, Intent } from "@blueprintjs/core";
Make a production build using webpack 4
Load and execute the page on IE11
Actual behavior
IE11 console errors: Object doesn't support property or method 'remove'
Expected behavior
No error should appear
Possible solution
It appears that the dom4 polyfill that includes the .remove() functionality is not included during the production build. This is because @blueprintjs/core is marked as sideEffect: false in package.json. Which means that webpack will cut away any unused imports/exports. Including the following lines which are responsible for loading in dom4:
Environment
Steps to reproduce
import { Position, Toaster, Intent } from "@blueprintjs/core";
Actual behavior
IE11 console errors: Object doesn't support property or method 'remove'
Expected behavior
No error should appear
Possible solution
It appears that the dom4 polyfill that includes the .remove() functionality is not included during the production build. This is because @blueprintjs/core is marked as sideEffect: false in package.json. Which means that webpack will cut away any unused imports/exports. Including the following lines which are responsible for loading in dom4:
blueprint/packages/core/src/components/index.ts
Lines 8 to 13 in b40b5a1
Solution is to mark this file as a sideEffect, see https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
The text was updated successfully, but these errors were encountered: