require("dom4") in esm code

[r-laf]

ReferenceError: Can't find variable: require in ./node_modules/@blueprintjs/core/lib/esm/index.js

where the error code is like

if (typeof window !== "undefined" && typeof document !== "undefined") {
    // we're in browser
    // tslint:disable-next-line:no-var-requires
    require("dom4"); // only import actual dom4 if we're in the browser (not server-compatible)
    // we'll still need dom4 types for the TypeScript to compile, these are included in package.json
}

Environment

"@blueprintjs/core": "^3.10.0",
safari on macOS Mojave

Expected behavior

'require' should not be in esm code

[r-laf]

it seems a dummy "require()" can work

[giladgray]

ooh interesting yeah makes sense this would happen. don't think we can do anything about it without an API break though. upgrading to typescript 3 and using import() would work, but the semantics are quite different. will track solving this soon.

[adidahiya]

This was fixed by #3868, I don't think we need to change anything here at the moment.