Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@bluprintjs/core bundle includes react-popper #3097

Closed
betalb opened this issue Oct 30, 2018 · 2 comments
Closed

@bluprintjs/core bundle includes react-popper #3097

betalb opened this issue Oct 30, 2018 · 2 comments

Comments

@betalb
Copy link

betalb commented Oct 30, 2018

Environment

  • @bluprintjs/core - 3.7.0
  • browser version is irrelevant

Steps to reproduce

  1. yarn add @blueprintjs/core
  2. check contents of node_modules/@blueprintjs/core/dist/coire.bundle.js

Actual behavior

Bundle includes sources of popper.js and react-popper

Expected behavior

Bundle should just require('react-popper') in UMD header (popper.js is dependency of react-popper)

Possible solution

Update https://github.com/palantir/blueprint/blob/develop/packages/webpack-build-scripts/externals.js and mark react-popper as external dependency

@giladgray
Copy link
Contributor

yeah oops gotta update list of externals.

@adidahiya
Copy link
Contributor

fixed by #3276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants