Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Lorem Ipsum with more representative text samples #139

Closed
adidahiya opened this issue Nov 14, 2016 · 9 comments · Fixed by #3635
Closed

Replace Lorem Ipsum with more representative text samples #139

adidahiya opened this issue Nov 14, 2016 · 9 comments · Fixed by #3635

Comments

@adidahiya
Copy link
Contributor

Throughout the docs examples we sometimes use Lorem ipsum and other times have nicer, more engaging text. Would be great to do a pass over the sample text and remove all instances of boring Lorem Ipsum.

@llorca
Copy link
Contributor

llorca commented Jan 17, 2017

@thisisalessandro any recommendation for nicer placeholder text?

@sonovawolf
Copy link

We should choose a non-Palantir theme and do a pass making it representative (but fictional).

@sonovawolf sonovawolf self-assigned this Jan 20, 2017
@tgreenwatts
Copy link
Contributor

So there are only 10 instances of "Lorem ipsum" being used today, think we can just close this out?

@llorca
Copy link
Contributor

llorca commented May 25, 2017

I think it's still a valid issue, just a P5 at this point. I will tackle it in June/July when I go through all the examples before we ship 2.0

@adidahiya adidahiya added this to the 2.0.0 milestone Feb 6, 2018
@giladgray
Copy link
Contributor

@llorca @thisisalessandro suggestions for lorem ipsum replacements?

@llorca
Copy link
Contributor

llorca commented Feb 7, 2018

First pass auditing where the lorem ipsum is:

  • Callouts: can't change the CSS ones, they're generated via intents
  • Cards: can change, will come up with something
  • Dialogs: can change, will come up with something
  • Popovers: can change, will come up with something

@giladgray
Copy link
Contributor

giladgray commented Feb 7, 2018

@adidahiya can we clarify the goal of this issue? my understanding is you're asking to replace all "lorem ipsum" instances (in both JS and CSS examples) with more engaging text.

two directions i could see this going (not mutually exclusive):

  • use a sillier text generator, like http://www.cipsum.com/ or http://fillerama.io/
  • more realistic examples, perhaps borrowed from OS components (great examples of dialogs and forms in OS X preferences, for instance)

@llorca
Copy link
Contributor

llorca commented Feb 8, 2018

I started working on this in between 3 other things, but IMO this isn't a requirement for 2.0

@giladgray
Copy link
Contributor

yeah it's just docs polish, can happen at any time

@giladgray giladgray modified the milestones: 2.0.0, 2.x Feb 8, 2018
adidahiya added a commit that referenced this issue Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants