From 78f65021fb67c774e9f48dc7ec63ae65d2449eb2 Mon Sep 17 00:00:00 2001 From: Adi Dahiya Date: Wed, 26 Feb 2020 16:56:47 -0500 Subject: [PATCH] =?UTF-8?q?[datetime]=20fix(DateRange):=20values=20are=20p?= =?UTF-8?q?ossibly=20null,=20not=20undefi=E2=80=A6=20(#3983)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fixes #3970 --- packages/datetime/src/common/dateUtils.ts | 2 +- packages/datetime/src/dateRangePicker.tsx | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/datetime/src/common/dateUtils.ts b/packages/datetime/src/common/dateUtils.ts index 278d6f738c..aeab64aa00 100644 --- a/packages/datetime/src/common/dateUtils.ts +++ b/packages/datetime/src/common/dateUtils.ts @@ -16,7 +16,7 @@ import { Months } from "./months"; -export type DateRange = [Date | undefined, Date | undefined]; +export type DateRange = [Date | null, Date | null]; export function isDateValid(date: Date | false | null): date is Date { return date instanceof Date && !isNaN(date.valueOf()); diff --git a/packages/datetime/src/dateRangePicker.tsx b/packages/datetime/src/dateRangePicker.tsx index 6465c13838..bda4374b61 100644 --- a/packages/datetime/src/dateRangePicker.tsx +++ b/packages/datetime/src/dateRangePicker.tsx @@ -347,7 +347,8 @@ export class DateRangePicker extends AbstractPureComponent2 { - Utils.safeInvoke(this.props.timePickerProps.onChange, newTime); + this.props.timePickerProps?.onChange?.(newTime); + const { value, time } = this.state; const newValue = DateUtils.getDateTime( value[dateIndex] != null ? DateUtils.clone(value[dateIndex]) : new Date(), @@ -357,7 +358,7 @@ export class DateRangePicker extends AbstractPureComponent2