Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid retries for overly large lock requests #3632

Open
sandorw opened this issue Nov 12, 2018 · 2 comments
Open

Avoid retries for overly large lock requests #3632

sandorw opened this issue Nov 12, 2018 · 2 comments

Comments

@sandorw
Copy link
Contributor

sandorw commented Nov 12, 2018

Internal reference: 77636

We should avoid retrying failed lock requests where the request fails because of a 413 - retries aren't going to help, and may actively overwhelm Timelock.

@sandorw
Copy link
Contributor Author

sandorw commented Nov 14, 2018

As per square/okhttp#1001, we don't even realize that it's a 413 and get a socket exception instead. Unfortunately, our retry logic on top of that is faulty (okhttp is configured to not retry at all at its layer) and means that we infinitely retry the request.

@sandorw
Copy link
Contributor Author

sandorw commented Jan 22, 2019

As part of addressing this, another scenario comes up in PDS-77976

Clients retry timed out lock requests (especially on the legacy lock service where requests may block forever), but the lock service may respond to one of the timed out requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant