Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to "relax" exact version of swiftui-introspect library? #16

Closed
xzilja opened this issue Mar 5, 2024 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@xzilja
Copy link

xzilja commented Mar 5, 2024

Started using CustomKeyboardKit today and it's a really pleasant library to work with! I was wondering if you would be open to possibility of relaxing version requirement of swiftui-introspect dependency from exact to "next major" or at least "next minor"?

Mainly, working in a project right now that uses latest version of this dependency 1.1.3 so it would be nice to share between libraries.

Alternatively, would you be open / what would it take to completely remove dependency on swiftui-introspect? If this is a viable idea, I'd be down to having a stab at this, with some help (i.e. bullet points of what needs to be done).

@paescebu
Copy link
Owner

paescebu commented Mar 5, 2024

@xzilja Hi!
Thanks for the positive feedback!
I think you're right. The version requirement for the dependency is something I haven't thought about much yet.

And indeed I'd be happy to help and relax the requirement. Introspect is as far as I can tell following semantic versioning very well. So I'd feel perfectly comfortable to use the "up to next major" rule.

Feel free to issue a Pull Request.
Otherwise I will apply the change myself in the next few days.

Thank you very much for the suggestion!

Kind regards
Pascal

@paescebu
Copy link
Owner

paescebu commented Mar 6, 2024

Fixed in 1.0.4

@paescebu paescebu closed this as completed Mar 6, 2024
@paescebu paescebu added the enhancement New feature or request label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants