From a9906c486f17832058148fc3b2d62b403a1909d1 Mon Sep 17 00:00:00 2001
From: Yousaf Nabi <yousaf@pactflow.io>
Date: Fri, 6 Sep 2024 18:37:53 +0100
Subject: [PATCH] fix: logFile default to info if undefined, warn if error
 setting

the existing enum FfiLogLevelFilter was not used, and its values

 LOG_LEVEL_* as not the same as LogLevel types

LogLevel = debug | error | info | trace | warn;

This fixes it for the verifier exposed in pact-js, automatically consuming this fix release.

pact-js consumer interfaces, still require updating to pass in the logFile argument.
---
 src/ffi/index.ts | 11 +++++++----
 src/ffi/types.ts | 11 +++++------
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/ffi/index.ts b/src/ffi/index.ts
index a6b567c1..9b486cac 100644
--- a/src/ffi/index.ts
+++ b/src/ffi/index.ts
@@ -132,11 +132,14 @@ export const getFfiLib = (
       logFile
     );
     if (logFile) {
-      logger.debug(
-        `writing log file at level ${FfiLogLevelFilter[logLevel]} to ${logFile}`
+      logger.debug(`writing log file at level ${logLevel} to ${logFile}`);
+      const res = ffiLib.pactffiLogToFile(
+        logFile,
+        FfiLogLevelFilter[logLevel] ?? 3
       );
-      const res = ffiLib.pactffiLogToFile(logFile, FfiLogLevelFilter[logLevel]);
-      logger.debug(`result of writing to file '${res}'`);
+      if (res !== 0) {
+        logger.warn(`Failed to write log file to ${logFile}, reason: ${res}`);
+      }
     } else {
       ffiLib.pactffiInitWithLogLevel(logLevel);
     }
diff --git a/src/ffi/types.ts b/src/ffi/types.ts
index 333177cb..8db460ce 100644
--- a/src/ffi/types.ts
+++ b/src/ffi/types.ts
@@ -110,12 +110,11 @@ export enum FfiFunctionResult {
 }
 
 export enum FfiLogLevelFilter {
-  LOG_LEVEL_OFF = 0,
-  LOG_LEVEL_ERROR,
-  LOG_LEVEL_WARN,
-  LOG_LEVEL_INFO,
-  LOG_LEVEL_DEBUG,
-  LOG_LEVEL_TRACE,
+  'error' = 1,
+  'warn' = 2,
+  'info' = 3,
+  'debug' = 4,
+  'trace' = 5,
 }
 
 export type Ffi = {