Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PactLogDir ignored in types.VerifyRequest #156

Closed
SergeyRadist opened this issue Mar 24, 2021 · 2 comments
Closed

PactLogDir ignored in types.VerifyRequest #156

SergeyRadist opened this issue Mar 24, 2021 · 2 comments

Comments

@SergeyRadist
Copy link

Software versions

  • OS: e.g. Mac OSX 10.11.5
  • Consumer Pact library: e.g. Pact go v1.5.1
  • Provider Pact library: e.g. pact-jvm-provider-maven_2.11 v 3.3.8
  • Golang Version: go version
  • Golang environment: Provide output of go env

Expected behaviour

	_, err := pact.VerifyProvider(t, types.VerifyRequest{
		PactLogDir: "/tmp/logs",
		PactLogLevel: "INFO",
	})

will cause writing logs in /tmp/logs with info level

Actual behaviour

logs written in default path

Steps to reproduce

use types.VerifyRequest

@SergeyRadist
Copy link
Author

Could I make pr ?

@mefellows
Copy link
Member

Ah, good spot. Just added the fix now and pushed to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants