Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Group.Heading to a separate component #261

Open
JonathanLorimer opened this issue May 16, 2024 · 1 comment
Open

Extract Group.Heading to a separate component #261

JonathanLorimer opened this issue May 16, 2024 · 1 comment
Labels

Comments

@JonathanLorimer
Copy link

Things like vanilla extract don't support styling arbitrary children using complex selectors like data selectors. It would be great to have an escape hatch and be able to pass your own class to certain components (like group headers).

Here is the discussion I started in the vanilla extract repo vanilla-extract-css/vanilla-extract#1411

@pacocoursey
Copy link
Owner

Agreed. A future update will make the Group header a separate component that forwards className.

@pacocoursey pacocoursey changed the title Would be great to be able to pass a class name as props instead of depending on data attributes Extract Group.Heading to a separate component May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants