Allow to use rpmlintrc files

Signed-off-by: Cristian Le <[email protected]>

Author: LecrisUT

plans/rpmlint/README.md

@@ -7,11 +7,13 @@ Run [rpmlint] on the current Copr project or Koji build
 ## Synopsis
 
 ```yaml
-plans:
-  import:
-    url: https://github.com/packit/tmt-plans
-    ref: main
-    name: /plans/rpmlint
+discover:
+  how: fmf
+  filter: "tag: rpmlint"
+  url: https://github.com/packit/tmt-plans
+  ref: main
+execute:
+  how: tmt
 ```
 
 ## Description
@@ -22,8 +24,9 @@ This plan simply runs the command
 $ rpmlint ./*.rpm
 ```
 
-Currently, there is no support to pass in additional `.rpmlintrc` due to limitations of the [`tmt`][tmt-import]
-interface. The `rpm` and `srpm` artifacts are taken from the testing-farm artifacts
+The `rpm` and `srpm` artifacts are taken from the testing-farm artifacts. In order to pass a `.rpmlintrc` file, use the
+[`prepare`] step of the plan to copy the file to `TMT_PLAN_DATA`. Only the `rpmlintrc` file that matches the spec file
+is used.
 
 :::note
 
@@ -39,11 +42,26 @@ No options available
 
 - Rpmlint the upstream packit project
   ```yaml
-  plans:
-    import:
-      url: https://github.com/packit/tmt-plans
-      ref: main
-      name: /plans/rpmlint
+  discover:
+    how: fmf
+    filter: "tag: rpmlint"
+    url: https://github.com/packit/tmt-plans
+    ref: main
+  execute:
+    how: tmt
+  ```
+- Use `rpmlintrc` file
+  ```yaml
+  prepare:
+    - how: shell
+      script: cp ./*.rpmlintrc $TMT_PLAN_DATA/
+  discover:
+    how: fmf
+    filter: "tag: rpmlint"
+    url: https://github.com/packit/tmt-plans
+    ref: main
+  execute:
+    how: tmt
   ```
 
 ## See Also
@@ -53,4 +71,4 @@ No options available
 <!-- SPHINX-END -->
 
 [rpmlint]: https://github.com/rpm-software-management/rpmlint
-[tmt-import]: https://tmt.readthedocs.io/en/stable/spec/plans.html#import-plans
+[`prepare`]: https://tmt.readthedocs.io/en/stable/spec/plans.html#prepare

plans/rpmlint/main.fmf

@@ -3,16 +3,5 @@ summary: Run rpmlint on all rpms and spec file
 description: |
   Equivalent to zuul job running rpmlint
 
-prepare:
-  - name: Get necessary packages
-    how: install
-    package:
-      - rpmlint
-      - tree
-  - name: Copy rpmlint toml configuration file
-    how: shell
-    script: cp plans/rpmlint/packit.toml $TMT_PLAN_DATA/packit.toml
-  # TODO: How to get the .rpmlintrc files?
-
 discover+:
   filter: "tag: rpmlint"

tests/rpmlint/main.fmf

@@ -1,4 +1,6 @@
 summary: Run rpmlint
 tag: rpmlint
+require:
+  - rpmlint
 
 test+: rpmlint.sh

plans/rpmlint/packit.toml tests/rpmlint/packit.toml

@@ -5,16 +5,31 @@
 rlJournalStart
 	rlPhaseStartSetup
 		rlRun "tmp=\$(mktemp -d)" 0 "Create tmp directory"
+		rlRun "work_dir=$(pwd)" 0 "Save original work_dir"
 		rlRun "pushd $tmp"
 		rlRun "set -o pipefail"
 		rlIsCentOS && rlLogWarning "rpmlint on CentOS+Epel is outdated. Reported information might not be relevant"
 	rlPhaseEnd
 
 	rlPhaseStartTest
+		if [[ -f "$TMT_PLAN_DATA/rpmlint.toml" ]]; then
+			# A custom rpmlint toml file was provided. Use that instead of the local files
+			rlRun "config_file=$TMT_PLAN_DATA/rpmlint.toml" 0 "Use config file from plan data"
+		else
+			# TODO: Use packit.toml only in packit context
+			rlRun "config_file=$work_dir/tests/rpmlint/packit.toml" 0 "Use the provided packit config file"
+		fi
 		rlRun "rpm2cpio /var/share/test-artifacts/*.src.rpm | cpio -civ '*.spec'" 0 "Extract spec file from srpm"
 		rlRun "cp ./*.spec $TMT_TEST_DATA/" 0 "Expose spec file"
+		# Dummy loop over spec file to extract the file name
+		for spec_file in *.spec; do
+			# Extract the base name from the file name and save it in BASH_REMATCH
+			[[ $spec_file =~ (.*).spec ]];
+			# Only use rpmlintrc file with the same name as the spec file
+			[[ -f "$TMT_PLAN_DATA/${BASH_REMATCH[1]}.rpmlintrc" ]] && rlRun "rc_file=$TMT_PLAN_DATA/${BASH_REMATCH[1]}.rpmlintrc" 0 "Use the rpmlintrc file of $spec_file"
+		done
 		# The spec rpmlint is already executed from the srpm
-		rlIsCentOS || rlRun "rpmlint -c $TMT_PLAN_DATA/packit.toml /var/share/test-artifacts/*.rpm" 0 "Run rpmlint (non-CentOS)"
+		rlIsCentOS || rlRun "rpmlint -c $config_file ${rc_file:+"-r $rc_file"} /var/share/test-artifacts/*.rpm" 0 "Run rpmlint (non-CentOS)"
 		rlIsCentOS && rlRun "rpmlint /var/share/test-artifacts/*.rpm || true" 0 "Run rpmlint (CentOS)"
 	rlPhaseEnd