Refactor Pagure and factory tests

- Fix Pagure tests
- `PagurePullRequest` - changed `project` -> `target_project`
- `test_add_user/group` - use user's playground
- `test_pr_status`
  - Use `head_commit` for setting commit status
  - Use `>=` instead of `==` for edited/created to prevent TZ problems

Signed-off-by: Matej Focko <[email protected]>

Author: mfocko

.pre-commit-config.yaml

@@ -11,8 +11,6 @@ repos:
     rev: 2.1.1
     hooks:
       - id: prettier
-        exclude: tests/integration/test_data/*
-        exclude: tests/integration/*/test_data/*
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v3.2.0
     hooks:

.prettierignore

@@ -0,0 +1 @@
+tests/integration/*/test_data/*

ogr/services/pagure/pull_request.py

@@ -69,7 +69,7 @@ def status(self) -> PRStatus:
     def url(self) -> str:
         return "/".join(
             [
-                self.project.service.instance_url,
+                self.target_project.service.instance_url,
                 self._raw_pr["project"]["url_path"],
                 "pull-request",
                 str(self.id),
@@ -264,7 +264,7 @@ def merge(self) -> "PullRequest":
 
     def get_statuses(self) -> List[CommitFlag]:
         self.__update()
-        return self.project.get_commit_statuses(self._raw_pr["commit_stop"])
+        return self.target_project.get_commit_statuses(self._raw_pr["commit_stop"])
 
     def set_flag(
         self,

tests/integration/factory/__init__.py

@@ -6,54 +6,52 @@ requests.sessions:
   send:
     GET:
       https://api.github.com/repos/packit/packit/installation:
-        - metadata:
-            latency: 0.4730544090270996
-            module_call_list:
-              - unittest.case
-              - requre.online_replacing
-              - tests.integration.github.test_app
-              - ogr.services.github.project
-              - ogr.services.github.service
-              - ogr.services.github.auth_providers.github_app
-              - github.MainClass
-              - requests.api
-              - requests.sessions
-              - requre.objects
-              - requre.cassette
-              - requests.sessions
-              - send
-          output:
-            __store_indicator: 2
-            _content:
-              documentation_url: https://docs.github.com/rest
-              message: A JSON web token could not be decoded
-            _next: null
-            elapsed: 0.2
-            encoding: utf-8
-            headers:
-              Access-Control-Allow-Origin: "*"
-              Access-Control-Expose-Headers:
-                ETag, Link, Location, Retry-After, X-GitHub-OTP,
-                X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes,
-                X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation,
-                Sunset
-              Content-Length: "102"
-              Content-Security-Policy:
-                default-src 'self';script-src 'self' 'nonce-YqLDC0BS8d7iY8mKO7VtBbIne'
-                https://apps.fedoraproject.org; style-src 'self' 'nonce-YqLDC0BS8d7iY8mKO7VtBbIne';
-                object-src 'none';base-uri 'self';img-src 'self' https:;
-              Content-Type: application/json; charset=utf-8
-              Date: Fri, 01 Nov 2019 13-36-03 GMT
-              Referrer-Policy: origin-when-cross-origin, strict-origin-when-cross-origin
-              Server: GitHub.com
-              Status: 401 Unauthorized
-              Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
-              Vary: Accept-Encoding, Accept, X-Requested-With
-              X-Content-Type-Options: nosniff
-              X-Frame-Options: deny
-              X-GitHub-Media-Type: github.v3; param=machine-man-preview; format=json
-              X-GitHub-Request-Id: 18FB:AA1A:99616C4:B8092CB:5CC15425
-              X-XSS-Protection: 1; mode=block
-            raw: !!binary ""
-            reason: Unauthorized
-            status_code: 401
+      - metadata:
+          latency: 0.4730544090270996
+          module_call_list:
+          - unittest.case
+          - requre.online_replacing
+          - tests.integration.github.test_app
+          - ogr.services.github.project
+          - ogr.services.github.service
+          - ogr.services.github.auth_providers.github_app
+          - github.MainClass
+          - requests.api
+          - requests.sessions
+          - requre.objects
+          - requre.cassette
+          - requests.sessions
+          - send
+        output:
+          __store_indicator: 2
+          _content:
+            documentation_url: https://docs.github.com/rest
+            message: A JSON web token could not be decoded
+          _next: null
+          elapsed: 0.2
+          encoding: utf-8
+          headers:
+            Access-Control-Allow-Origin: '*'
+            Access-Control-Expose-Headers: ETag, Link, Location, Retry-After, X-GitHub-OTP,
+              X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes,
+              X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation,
+              Sunset
+            Content-Length: '102'
+            Content-Security-Policy: default-src 'self';script-src 'self' 'nonce-YqLDC0BS8d7iY8mKO7VtBbIne'
+              https://apps.fedoraproject.org; style-src 'self' 'nonce-YqLDC0BS8d7iY8mKO7VtBbIne';
+              object-src 'none';base-uri 'self';img-src 'self' https:;
+            Content-Type: application/json; charset=utf-8
+            Date: Fri, 01 Nov 2019 13-36-03 GMT
+            Referrer-Policy: origin-when-cross-origin, strict-origin-when-cross-origin
+            Server: GitHub.com
+            Status: 401 Unauthorized
+            Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
+            Vary: Accept-Encoding, Accept, X-Requested-With
+            X-Content-Type-Options: nosniff
+            X-Frame-Options: deny
+            X-GitHub-Media-Type: github.v3; param=machine-man-preview; format=json
+            X-GitHub-Request-Id: 18FB:AA1A:99616C4:B8092CB:5CC15425
+            X-XSS-Protection: 1; mode=block
+          raw: !!binary ""
+          reason: Unauthorized
+          status_code: 401