Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

PFS: "all commits" should not be referenced as commitSet - (Parity with core Pachyderm 2.0) #316

Closed
echohack opened this issue Aug 6, 2021 · 0 comments · Fixed by #323
Closed

Comments

@echohack
Copy link
Contributor

echohack commented Aug 6, 2021

Hello,

This morning I discovered we are calling "all commits" a commitSet in python-pachyderm. My understanding is that in pachctl we have abandoned the idea of a commitSet. I would expect the names of the methods and their behaviors to be updated to match the new behavior of pachctl.

def inspect_commit_set(

See also: #313

This was changed fairly recently (beta.2) in core Pachyderm 2.0.

@smalyala smalyala mentioned this issue Aug 12, 2021
4 tasks
@smalyala smalyala linked a pull request Aug 19, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant