Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Pair syntax for sublats kwarg in hopping #29

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Apr 13, 2020

Addresses one of the points in #19

This simplifies and extends the sublats keyword in hopping. A hoppings from sublat :A to sublat :B is now always denoted with :A => :B. The PR also allows for broadcasting between two groups of sublattices (:A, :B) .=> (:A, :B) (equivalent to (:A => :A, :B => :B)), and even direct product, (:A, :B) => (:C, :D) (equivalent to (:A=>:C,:A=>:D,:B=>:C,:B=>:D)).

Updated and extended also the docstrings for hopping and onsite, and added an internal method Quantica.sublats(model) that returns the sublats of each term in model.

@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #29 into master will increase coverage by 0.36%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   47.93%   48.29%   +0.36%     
==========================================
  Files          14       14              
  Lines        2078     2081       +3     
==========================================
+ Hits          996     1005       +9     
+ Misses       1082     1076       -6     
Impacted Files Coverage Δ
src/tools.jl 68.00% <77.77%> (+2.50%) ⬆️
src/hamiltonian.jl 42.41% <100.00%> (ø)
src/model.jl 70.34% <100.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e850cbc...59c3154. Read the comment docs.

@pablosanjose pablosanjose merged commit 277ebc6 into master Apr 13, 2020
@pablosanjose pablosanjose deleted the sublats branch April 14, 2020 10:09
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.29%. Comparing base (e850cbc) to head (59c3154).
Report is 1387 commits behind head on master.

Files with missing lines Patch % Lines
src/tools.jl 77.77% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   47.93%   48.29%   +0.36%     
==========================================
  Files          14       14              
  Lines        2078     2081       +3     
==========================================
+ Hits          996     1005       +9     
+ Misses       1082     1076       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants