Fix compatibility issues with v1.7+ #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reintroduce nightly in CI
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 72.08% 72.39% +0.30%
==========================================
Files 19 19
Lines 3786 3785 -1
==========================================
+ Hits 2729 2740 +11
+ Misses 1057 1045 -12
Continue to review full report at Codecov.
|
pablosanjose
changed the title
|
There was another issue with the use of findmin/findmax where we actually want argmin/argmax in latest 1.7 Julia. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Max-Borovkov encountered an ambiguity issue with
qr(::SMatrix)that arose after JuliaLang/julia#40623. Until StaticArrays.jl catches up and/or Julialang fixes the ambiguity, this PR creates a special codepath for v1.7-beta2+ that employs the updatedqr(::SMatrix, NoPivot())explicit syntax. Also added nightly to CI, let's see what it says.