Fix for complex spectra #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 59.83% 57.26% -2.58%
==========================================
Files 16 16
Lines 2791 2623 -168
==========================================
- Hits 1670 1502 -168
Misses 1121 1121
Continue to review full report at Codecov.
|
comment fix test unrelated fix another fix
pablosanjose
force-pushed
the
simplediago
branch
from
1b65c4e to
1591ec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex eigenvalues made the merging of degeneracies in bandstructure trip. We fix this by making a smarter
Subspacetype that converts complex eigenvalues to the type of momenta. We also make sure theapproxruns::Runsiterator deals with complex eigenvalues correctly.