Another bandstructure overhaul: linecuts and parametric mappings #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77
This implements the design at the end of in #77. In summary
mapping
s (renamed fromlift
s) inbandstructure
that take kwargs in theParametricHamiltonian
caseNote that the number of Bloch phases preceding the NamedTuple must now exactly match the
Hamiltonian
's (or ParametricHamiltonian`s) lattice dimensionWe build meshes with
mesh
now, notmarchingmesh
.We deprecate
linearmesh
in favor of the syntaxbandstructure(h, nodes...; points = 13, kw...)
. We can now do things likebandstructure
withtransform = (fv, fϵ)
, wherefv
now transforms the mesh, andfϵ
the eigenvalues. Optionally we can dotransform = isometric
ortransform = (isometric, fϵ)
to transform the mesh into momenta, assuming the mesh spans Bloch phases.