Bandstructure overhaul: Dual numbers and smart band extraction #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78
Addresses this kind of artifacts
This is a rework of the
bandstructure
internals, in particular the resolution of degeneracies and the extraction of bands using eigenvector projections. In summarypending
list, and iteration is done bypop!
-ing the last added vertex untilpending
is emptyminoverlap
inbandstructure
is now 0, as eager band extraction is now working as expectedThere is only the edge case of Dirac cones pending, which will still require point splitting (future PR)