Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch does not cover the entire window on retina displays. #9

Closed
abhikpal opened this issue Aug 15, 2017 · 3 comments
Closed

Sketch does not cover the entire window on retina displays. #9

abhikpal opened this issue Aug 15, 2017 · 3 comments

Comments

@abhikpal
Copy link
Member

abhikpal commented Aug 15, 2017

Test script: p5-examples/basics/color/color_variables.py

Expected behavior:
screenshot from 2017-08-16 04-16-44

Actual behavior

screen shot 2017-08-04 at 11 58 01 am

Errors produced (if any): None

p5 version: 2b96dfc

Python version: Python 3.6
Operating System: Mac OS

@marcrleonard
Copy link

I can confirm this is still the case. I assume there is not a DPI function like there is in p5.js?

@marcrleonard
Copy link

marcrleonard commented Dec 10, 2017

I took a look at how p5.js did this, and it wasn't a feature like I original thought. They just add a multiplier in the dom. I was able to fix it by basically adding a density= kwarg to the size() in setup. After digging deep into how pyglet is 'grabbing' the resolution, I think it's impossible to get the native resolution (it's .5 the actual resolution). But! Funny enough, the actual pixel rendering is correct. So it's just the pyglet window that gets scaled down to the proper size. I'll attempt to do a pull request later (never done one before!)

Further reading about the OSX issue (but it's as if it was fixed... https://bitbucket.org/pyglet/pyglet/issues/45/retina-display-scaling-on-os-x)

@abhikpal abhikpal added this to the Pre-VisPy release milestone Jun 5, 2018
@abhikpal abhikpal self-assigned this Jun 5, 2018
@abhikpal abhikpal modified the milestones: Pre-VisPy release, Port backend to VisPy Jun 12, 2018
@swirly
Copy link

swirly commented Sep 27, 2019

issue still revelant for me. Anaconda python last version (python 3.7), p5py, vispy and pyglet installed with pip

# pip install p5py pyglet vispy
Requirement already satisfied: p5py in /Users/laurent/anaconda3/lib/python3.7/site-packages (1.0.0)
Requirement already satisfied: pyglet in /Users/laurent/anaconda3/lib/python3.7/site-packages (1.4.4)
Requirement already satisfied: vispy in /Users/laurent/anaconda3/lib/python3.7/site-packages (0.6.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants