Skip to content

Commit 9703cad

Browse files
committed
Disabled ignore callback error in Emitter Groups, for vispy to terminate the program when some error occurs. commit-credits: Mark :p
1 parent 151745b commit 9703cad

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

.github/workflows/sanityTesting.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,7 @@ jobs:
2020
python -m pip install --upgrade pip
2121
pip install wheel
2222
pip install .
23-
# - name: Set env
24-
# # TODO: Find an alternate way to get the path, instead of hard-coding
25-
# run: echo "PYTHONPATH=$PYTHONPATH:${HOME}/work/p5" >> $GITHUB_ENV
26-
# - name: Test
27-
# run: echo $PYTHONPATH
28-
- name: Setup virtual frame buffer
23+
- name: Run headless tests
2924
uses: GabrielBB/xvfb-action@v1
3025
with:
3126
run: python p5/visualTests/sanity_testing.py

p5/sketch/Vispy2DRenderer/base.py

+2
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,15 @@ def __init__(self, setup_method, draw_method,
6767
resizable=True,
6868
)
6969

70+
self.events.ignore_callback_errors = False
7071
self.setup_method = setup_method
7172
self.draw_method = draw_method
7273

7374
self.looping = None
7475
self.redraw = None
7576
self.setup_done = False
7677
self.timer = app.Timer(1.0 / frame_rate, connect=self.on_timer)
78+
self.timer.events.ignore_callback_errors = False
7779

7880
self.handlers = dict()
7981
for handler_name in handler_names:

p5/visualTests/Instructions.md

+3-5
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@
33
python sanity_testing.py
44
```
55

6-
**NOTE**: If you get a `ModuleNotFound or ImportError` make sure you export the `project's root path` to `PYTHONPATH` variable.
6+
**NOTE**: If you get a `ModuleNotFound or ImportError` make sure install the project using
77

88
```
9-
export PYTHONPATH=$PYTHONPATH:path/to/project"
10-
```
11-
12-
Or you could either use [rootpath](https://pypi.org/project/rootpath/) to find the project's rootpath and then export the path.
9+
pip install path/to/p5
10+
```

0 commit comments

Comments
 (0)