From 1937f8ceceb764596491b121ad31676e259f1f37 Mon Sep 17 00:00:00 2001 From: Adarsh Date: Sat, 13 Apr 2024 20:19:45 +0530 Subject: [PATCH 1/8] Fix: Link to P4_16 specification --- backends/ebpf/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/ebpf/README.md b/backends/ebpf/README.md index 6a4a7992c32..3b5bdcb22f6 100644 --- a/backends/ebpf/README.md +++ b/backends/ebpf/README.md @@ -37,7 +37,7 @@ Communications Review in 2014: P4 itself is protocol-independent but allows programmers to express a rich set of data plane behaviors and protocols. This back-end only supports the newest version of the P4 programming language, -[P4_16](http://p4.org/wp-content/uploads/2016/12/P4_16-prerelease-Dec_16.html). +[P4_16](https://p4.org/p4-spec/docs/P4-16-v-1.2.3.html). The core P4 abstractions are: * Headers describe the format (the set of fields and their From 110f67fd969f2788dacb2a0acc9bc7fda5476db0 Mon Sep 17 00:00:00 2001 From: Adarsh Date: Sat, 13 Apr 2024 20:42:58 +0530 Subject: [PATCH 2/8] Fix : Link to Contribution Guidelines --- backends/p4tools/modules/testgen/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/p4tools/modules/testgen/README.md b/backends/p4tools/modules/testgen/README.md index 3acc04ae24d..3bcb7fa7e6b 100644 --- a/backends/p4tools/modules/testgen/README.md +++ b/backends/p4tools/modules/testgen/README.md @@ -152,7 +152,7 @@ If you would like to cite this work please use this citation format: ## Contributing -Contributions to P4Testgen in any form are welcome! Please follow the guidelines listed [here](https://github.com/p4lang/p4c/tree/main/docs) to contribute. +Contributions to P4Testgen in any form are welcome! Please follow the guidelines listed [here](https://github.com/p4lang/p4c/blob/main/CONTRIBUTING.md) to contribute. ## License From 2592d7dd4572ebaebd4d723eb45ebcb81df68efa Mon Sep 17 00:00:00 2001 From: Adarsh Rawat Date: Sat, 13 Apr 2024 23:08:49 +0530 Subject: [PATCH 3/8] Fix : Link to P4_16 Specification --- backends/ebpf/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/ebpf/README.md b/backends/ebpf/README.md index 3b5bdcb22f6..5f67483f2aa 100644 --- a/backends/ebpf/README.md +++ b/backends/ebpf/README.md @@ -37,7 +37,7 @@ Communications Review in 2014: P4 itself is protocol-independent but allows programmers to express a rich set of data plane behaviors and protocols. This back-end only supports the newest version of the P4 programming language, -[P4_16](https://p4.org/p4-spec/docs/P4-16-v-1.2.3.html). +[P4_16]( https://p4.org/specs). The core P4 abstractions are: * Headers describe the format (the set of fields and their From ede468df22edab42d53622caf3f893afd5f33a33 Mon Sep 17 00:00:00 2001 From: Adarsh Date: Sat, 20 Apr 2024 10:51:34 +0530 Subject: [PATCH 4/8] [Fix] bpf kernel helpers link --- backends/ebpf/runtime/ebpf_kernel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/ebpf/runtime/ebpf_kernel.h b/backends/ebpf/runtime/ebpf_kernel.h index 1fd64806eea..24f4deb9c7f 100644 --- a/backends/ebpf/runtime/ebpf_kernel.h +++ b/backends/ebpf/runtime/ebpf_kernel.h @@ -46,7 +46,7 @@ limitations under the License. /* If we operate in user space we only need to include bpf.h and * define the userspace API macros. * For kernel programs we need to specify a list of kernel helpers. These are - * taken from here: https://github.com/torvalds/linux/blob/master/tools/testing/selftests/bpf/bpf_helpers.h + * taken from here: https://github.com/torvalds/linux/blob/master/tools/lib/bpf/bpf_helpers.h */ #ifdef CONTROL_PLANE // BEGIN EBPF USER SPACE DEFINITIONS From 1d4433068bb70f6aa4f661bad29cb7f6dfd356af Mon Sep 17 00:00:00 2001 From: Adarsh Date: Sat, 20 Apr 2024 10:59:17 +0530 Subject: [PATCH 5/8] [Fix] Google "styleguide" outdated links in cpplint.py --- tools/cpplint.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/cpplint.py b/tools/cpplint.py index a4e979af0d1..ca912f883d4 100755 --- a/tools/cpplint.py +++ b/tools/cpplint.py @@ -3587,7 +3587,7 @@ def CheckForFunctionLengths(filename, clean_lines, linenum, """Reports for long function bodies. For an overview why this is done, see: - https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions + https://google.github.io/styleguide/cppguide.html#Write_Short_Functions Uses a simplistic algorithm assuming other style guidelines (especially spacing) are followed. @@ -5423,7 +5423,7 @@ def CheckLanguage(filename, clean_lines, linenum, file_extension, and line[-1] != '\\'): error(filename, linenum, 'build/namespaces_headers', 4, 'Do not use unnamed namespaces in header files. See ' - 'https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces' + 'https://google.github.io/styleguide/cppguide.html#Namespaces' ' for more information.') From 9f16356b8a0912041faaa1edfe5d9cd503f5b10a Mon Sep 17 00:00:00 2001 From: Adarsh Date: Sat, 20 Apr 2024 11:14:23 +0530 Subject: [PATCH 6/8] [Fix] link to "fabric" resources in "onos" --- testdata/p4_16_samples/fabric_20190420/fabric.p4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testdata/p4_16_samples/fabric_20190420/fabric.p4 b/testdata/p4_16_samples/fabric_20190420/fabric.p4 index 7eb89d9676b..5b70113a1b7 100644 --- a/testdata/p4_16_samples/fabric_20190420/fabric.p4 +++ b/testdata/p4_16_samples/fabric_20190420/fabric.p4 @@ -17,7 +17,7 @@ // All of the P4 source files in this directory were copied from the // following location on 2019-Apr-20: -// https://github.com/opennetworkinglab/onos/blob/master/pipelines/fabric/src/main/resources +// https://github.com/opennetworkinglab/onos/blob/master/pipelines/fabric/impl/src/main/resources // The only changes made were: From 19950a1b3d0cabefaf162a22b70d965ceef032a2 Mon Sep 17 00:00:00 2001 From: Adarsh Date: Sat, 20 Apr 2024 11:20:26 +0530 Subject: [PATCH 7/8] [Fix] v1model-special-ops guide link --- testdata/p4_14_samples/p414-special-ops-2-bmv2.stf | 2 +- testdata/p4_14_samples/p414-special-ops-3-bmv2.stf | 2 +- testdata/p4_14_samples/p414-special-ops.stf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testdata/p4_14_samples/p414-special-ops-2-bmv2.stf b/testdata/p4_14_samples/p414-special-ops-2-bmv2.stf index 4c26e461168..0eaf98a6505 100644 --- a/testdata/p4_14_samples/p414-special-ops-2-bmv2.stf +++ b/testdata/p4_14_samples/p414-special-ops-2-bmv2.stf @@ -2,7 +2,7 @@ # For details on the behavior of this program with these input # packets, and how they should produce these expected output packets, -# see https://github.com/jafingerhut/p4-guide/tbd/README-p414.md +# see https://github.com/jafingerhut/p4-guide/blob/master/v1model-special-ops/README-p414.md # test resubmit operation diff --git a/testdata/p4_14_samples/p414-special-ops-3-bmv2.stf b/testdata/p4_14_samples/p414-special-ops-3-bmv2.stf index 57282c3298f..4d9b55239b7 100644 --- a/testdata/p4_14_samples/p414-special-ops-3-bmv2.stf +++ b/testdata/p4_14_samples/p414-special-ops-3-bmv2.stf @@ -2,7 +2,7 @@ # For details on the behavior of this program with these input # packets, and how they should produce these expected output packets, -# see https://github.com/jafingerhut/p4-guide/tbd/README-p414.md +# see https://github.com/jafingerhut/p4-guide/blob/master/v1model-special-ops/README-p414.md # test resubmit operation diff --git a/testdata/p4_14_samples/p414-special-ops.stf b/testdata/p4_14_samples/p414-special-ops.stf index 4c26e461168..0eaf98a6505 100644 --- a/testdata/p4_14_samples/p414-special-ops.stf +++ b/testdata/p4_14_samples/p414-special-ops.stf @@ -2,7 +2,7 @@ # For details on the behavior of this program with these input # packets, and how they should produce these expected output packets, -# see https://github.com/jafingerhut/p4-guide/tbd/README-p414.md +# see https://github.com/jafingerhut/p4-guide/blob/master/v1model-special-ops/README-p414.md # test resubmit operation From 034d957c566ef05b816c4bb335767ea43a7f12ad Mon Sep 17 00:00:00 2001 From: Adarsh Rawat Date: Wed, 24 Apr 2024 19:53:13 +0530 Subject: [PATCH 8/8] [Docs] Add annotation for Historic reference of 'bcc' --- backends/ebpf/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/ebpf/README.md b/backends/ebpf/README.md index 5f67483f2aa..ba95dcee530 100644 --- a/backends/ebpf/README.md +++ b/backends/ebpf/README.md @@ -5,7 +5,7 @@ The back-end accepts only P4_16 code written for the `ebpf_model.p4` or compiled into [eBPF (extended Berkeley Packet Filters)](https://en.wikipedia.org/wiki/Berkeley_Packet_Filter) using clang/llvm or [bcc](https://github.com/iovisor/bcc.git). -An older version of this compiler for compiling P4_14 is available [here](https://github.com/iovisor/bcc/tree/master/src/cc/frontends/p4). +An older version of this compiler for compiling P4_14 is available [here](https://github.com/iovisor/bcc/tree/master/src/cc/frontends/p4) (historical reference only). Identifiers starting with ebpf_ are reserved in P4 programs, including for structure field names.