Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper inversion generation #35

Open
donRumata03 opened this issue Jan 26, 2022 · 0 comments
Open

Proper inversion generation #35

donRumata03 opened this issue Jan 26, 2022 · 0 comments

Comments

@donRumata03
Copy link

Is that correct that there are only n inversions generated where n is the number of notes in the chord?

notes.rotate_left(self.inversion as usize);

As far as I understand, there should be n! of them to produce all the permutations.

AFAIK, according to the music theory, there only exists the invariant that the notes in chords shouldn't contain spaces more than one octave and this reduces the number of inversions of a given chord starting for a given octave exactly n!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant