Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pentatonic and other non-heptatonic scales (and their modes) #11

Open
XBagon opened this issue May 2, 2020 · 1 comment
Open

Pentatonic and other non-heptatonic scales (and their modes) #11

XBagon opened this issue May 2, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@XBagon
Copy link
Contributor

XBagon commented May 2, 2020

I feel like, when wanting to add more complex scales and modes, a small rework of ScaleType and Mode has to be done.
Both are targeted at 7-tone scales and I guess it would need enums for mode and scale for each n-tone scale. Or maybe I'm missing some music-theoretical concept.
I'm willing to add these features, but might need a bit more direction.

@ozankasikci
Copy link
Owner

I believe there are more important issues than implementing more complex scale types atm. Please check the Roadmap in the README, i would love to get some help with finishing up the implementation of minor scales instead, which is the first bullet point in the Roadmap.

@ozankasikci ozankasikci added enhancement New feature or request help wanted Extra attention is needed labels May 3, 2020
@ozankasikci ozankasikci removed the help wanted Extra attention is needed label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants